[PATCH] D79820: [test] Improve FileCheck's numeric-expression.txt

Joel E. Denny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 14 10:16:49 PDT 2020


jdenny marked an inline comment as done.
jdenny added inline comments.


================
Comment at: llvm/test/FileCheck/numeric-expression.txt:156
+USE MULTI VAR  // CHECK-LABEL: USE MULTI VAR
+31  // CHECK-NEXT: {{^}}[[#VAR4:]]
+42  // CHECK-NEXT: {{^}}[[#UNSI+VAR4]]
----------------
jdenny wrote:
> For consistency with VAR42, should VAR4 become VAR31?
Nevermind this.

Looks like this was the only additional change after the diff I reviewed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79820/new/

https://reviews.llvm.org/D79820





More information about the llvm-commits mailing list