[PATCH] D78558: [Support] Make DataExtractor error messages more clear

[Pavel Labath via Phabricator via llvm-commits]

labath marked 7 inline comments as done.
labath added inline comments.
Herald added a subscriber: cmtice.


================
Comment at: llvm/include/llvm/Support/DataExtractor.h:696
+  /// error object to indicate an error.
+  bool prepareRead(uint64_t Offset, uint64_t Size, Error *E) const;
+
----------------
jhenderson wrote:
> labath wrote:
> > jhenderson wrote:
> > > Any particular reason this is `protected`, not `private`?
> > There is, though it's fairly arbitrary -- it seemed like it could be useful to subclasses like DWARFDataExtractor.
> Fair enough. I'll leave it up to you to decide what would be best.
Actually, I'll just make it private. It's easy to make it protected if needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78558/new/

https://reviews.llvm.org/D78558