[PATCH] D79780: [LLD][ELF] Add lld -time-trace to man page and release notes

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 14 09:11:04 PDT 2020


MaskRay requested changes to this revision.
MaskRay added inline comments.
This revision now requires changes to proceed.


================
Comment at: lld/docs/ReleaseNotes.rst:27
 
+* New ``-time-trace`` option records a time trace file that can be viewed in
+  chrome://tracing. The file can be specified with ``-time-trace-file``.  Trace
----------------
russell.gallop wrote:
> MaskRay wrote:
> > `--time-trace`
> > 
> > Also, the feature was added in the last release. It is not correct to mention it for LLD 11.
> > --time-trace
> 
> Thanks for pointing that out.
> 
> > Also, the feature was added in the last release. It is not correct to mention it for LLD 11.
> 
> That would be a surprise to me. I can't see an equivalent of e7cb374433095219069ef767f70c0c9159a65b7c in release/10.x.
> 
> Please can you let me know why you think that this was in the last release?
> 
> Thanks
> 
I somehow thought `--time-trace` was included in release/10.x. It turns out it is not. Adding it for 11 release notes seem good.


================
Comment at: lld/docs/ld.lld.1:535
 disables multi-threading.
+.It Fl --time-trace
+Record time trace.
----------------
`--` to `-`

Fl carries a dash by itself.

You can read the man page with `man docs/ld.lld.1`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79780/new/

https://reviews.llvm.org/D79780





More information about the llvm-commits mailing list