[PATCH] D60392: FileCheck [12/12]: Support use of var defined on same line
Thomas Preud'homme via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 14 09:11:02 PDT 2020
thopre added a comment.
In D60392#2035853 <https://reviews.llvm.org/D60392#2035853>, @jhenderson wrote:
> In D60392#2033995 <https://reviews.llvm.org/D60392#2033995>, @thopre wrote:
>
> > Perhaps the solution is to forbid using a variable defined on the same line for a CHECK-NOT directive? In all other cases we'll get a false negative (directive not satisfied) instead of a false positive (directive satisfied).
>
>
> Hmm, you make a fair argument, and I think this suggestion might work. I'll need to give it more thought though. Perhaps it needs a mailing list thread to get more eyes on this?
That was my intention. I'm focusing on D60390 <https://reviews.llvm.org/D60390> for now, then I'll start a thread.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D60392/new/
https://reviews.llvm.org/D60392
More information about the llvm-commits
mailing list