[PATCH] D79939: Implement --dependent-libraries for GNU output

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 14 08:05:50 PDT 2020


grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/ELF/dependent-libraries.test:7
 
 # RUN: yaml2obj --docnum=1 %s -o %t1
+# RUN: llvm-readobj --dependent-libraries %t1 | \
----------------
jhenderson wrote:
> grimar wrote:
> > Probably it worth to mention that `--dependent-libraries` is not implemented in GNU at the moment of 14 may 2020.
> I'm not sure I follow. This change is adding support for GNU.
I mean GNU readelf does not implement this, right? So it is the difference we have atm.
Perhaps worth to mention it in a comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79939/new/

https://reviews.llvm.org/D79939





More information about the llvm-commits mailing list