[PATCH] D79820: [test] Improve FileCheck's numeric-expression.txt

[Joel E. Denny via Phabricator via llvm-commits]

jdenny accepted this revision.
jdenny added a comment.

In D79820#2035779 <https://reviews.llvm.org/D79820#2035779>, @jhenderson wrote:

> LGTM, but please wait for @jdenny to confirm.


Other than the comment I just added, this much LGTM as well.

> Is there any particular reason for you not to make the same improvements, re. comments inline, on the other sets of tests?

Agreed.



================
Comment at: llvm/test/FileCheck/numeric-expression.txt:66
 ; variables defined on other lines without spaces.
-USE DEF FMT IMPL MATCH
-11
-12
-10
-c
-d
-b
-1a
-D
-E
-C
-1B
-11
-11
-11
-c
-c
-c
-c
-c
-CHECK-LABEL: USE DEF FMT IMPL MATCH
-CHECK-NEXT: [[#%u,VAR1]]
-CHECK-NEXT: [[#%u,VAR1+1]]
-CHECK-NEXT: [[#%u,VAR1-1]]
-CHECK-NEXT: [[#%x,VAR2]]
-CHECK-NEXT: [[#%x,VAR2+1]]
-CHECK-NEXT: [[#%x,VAR2-1]]
-CHECK-NEXT: [[#%x,VAR2+14]]
-CHECK-NEXT: [[#%X,VAR3]]
-CHECK-NEXT: [[#%X,VAR3+1]]
-CHECK-NEXT: [[#%X,VAR3-1]]
-CHECK-NEXT: [[#%X,VAR3+14]]
-CHECK-NEXT: [[#%u,VAR1a]]
-CHECK-NEXT: [[#%u,VAR1b]]
-CHECK-NEXT: [[#%u,VAR1c]]
-CHECK-NEXT: [[#%x,VAR2a]]
+USE DEF FMT IMPL MATCH  // CHECK-LABEL: USE DEF FMT IMPL MATCH
+11  // CHECK-NEXT: [[#%u,VAR1]]     {{.*}}
----------------
Should `DEF` here be `EXPL` as in the next block?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79820/new/

https://reviews.llvm.org/D79820