[PATCH] D79936: [FileCheck] Add function call support to numerical expressions.

Alexander Richardson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 14 06:58:06 PDT 2020


arichardson added a comment.

I like this approach. Starting functions with `!` seems reasonable since it is similar tablegen and if we decide that we don't need the prefix, we can always drop it.
The advantage of requiring the prefix is that we can give functions names that might also be commonly used capture names.

There should probably be some tests for error messages in llvm/unittests/Support/FileCheckTest.cpp.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79936/new/

https://reviews.llvm.org/D79936





More information about the llvm-commits mailing list