[PATCH] D79928: [RISCV] Make visibility of overridden methods in RISCVISelLowering match the parent

Sam Elliott via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 14 04:47:36 PDT 2020


lenary accepted this revision.
lenary added a comment.
This revision is now accepted and ready to land.

I am in favour of this reasoning around matching the visibility - it serves downstream users best (in general), and there's no good reason not to allow people to subclass these classes for their own usage (though I don't know how much this happens in reality).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79928/new/

https://reviews.llvm.org/D79928





More information about the llvm-commits mailing list