[PATCH] D78105: [CSInfo][ISEL] Call site info generation support for Mips

[Nikola Tesic via Phabricator via llvm-commits]

ntesic marked 2 inline comments as done.
ntesic added a comment.





================
Comment at: llvm/test/CodeGen/Mips/call-site-info-output.ll:34
+; CHECK-NEXT:   arg: 2, reg: '$a2'
+;; Verify that we are able to parse output mir and that we are getting the same result.
+; PARSER: name: fn2
----------------
dstenb wrote:
> This comment says that we parse output MIR, but the PARSER commands take IR as input?
> 
> ```
> RUN: llc -mtriple=mips-linux-gnu -emit-call-site-info %s -stop-after=finalize-isel -o -| FileCheck %s --check-prefix=PARSER
> ```
> 
> To test MIR parsing, perhaps we can just combine the two RUN lines into something like this?
> 
> ```
> llc %s -stop-after=finalize-isel -o - | llc -run-pass=finalize-isel -o - | Filecheck %s
> ```
> 
> And if we keep two separate RUN invocations, the `CHECK` and `PARSER` are identical as far as I can tell, so can we combine them to one group then?
Thanks for pointing out this.
I agree with your suggestions and I have fixed RUN lines.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78105/new/

https://reviews.llvm.org/D78105