[PATCH] D79812: [MLIR] Add symbol map to mlir ExecutionEngine

Mehdi AMINI via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 13 17:29:43 PDT 2020


mehdi_amini accepted this revision.
mehdi_amini added a comment.

LG, thanks!



================
Comment at: mlir/include/mlir/ExecutionEngine/ExecutionEngine.h:115
 
+  /// Register symbols with an underlying JIT-compilation engine.
+  void registerSymbols(
----------------
Nit comment should read "with this ExecutionEngine", "an" is a bit undefined / seems to refer to another object.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79812/new/

https://reviews.llvm.org/D79812





More information about the llvm-commits mailing list