[llvm] 4f4b5b9 - [cmake] Need PUBLIC dependencies for object targets even if LLVM_PTHREAD_LIB is unset

Stephen Neuendorffer via llvm-commits llvm-commits at lists.llvm.org
Wed May 13 17:20:10 PDT 2020


Author: Stephen Neuendorffer
Date: 2020-05-13T17:19:32-07:00
New Revision: 4f4b5b98a2a08461babd1e851a55acd37dd33c96

URL: https://github.com/llvm/llvm-project/commit/4f4b5b98a2a08461babd1e851a55acd37dd33c96
DIFF: https://github.com/llvm/llvm-project/commit/4f4b5b98a2a08461babd1e851a55acd37dd33c96.diff

LOG: [cmake] Need PUBLIC dependencies for object targets even if LLVM_PTHREAD_LIB is unset

Fix logic in previous patch.

Added: 
    

Modified: 
    llvm/cmake/modules/AddLLVM.cmake

Removed: 
    


################################################################################
diff  --git a/llvm/cmake/modules/AddLLVM.cmake b/llvm/cmake/modules/AddLLVM.cmake
index 278f3fa8d49d..7c568f0b584b 100644
--- a/llvm/cmake/modules/AddLLVM.cmake
+++ b/llvm/cmake/modules/AddLLVM.cmake
@@ -483,11 +483,13 @@ function(llvm_add_library name)
         "PUBLIC;PRIVATE"
         ${ARG_LINK_LIBS})
       foreach(link_lib ${LINK_LIBS_ARG_PUBLIC})
-        # Can't specify a dependence on -lpthread
         if(LLVM_PTHREAD_LIB)
+          # Can't specify a dependence on -lpthread
           if(NOT ${link_lib} STREQUAL ${LLVM_PTHREAD_LIB})
             add_dependencies(${obj_name} ${link_lib})
           endif()
+        else()
+          add_dependencies(${obj_name} ${link_libs})
         endif()
       endforeach()
     endif()


        


More information about the llvm-commits mailing list