[PATCH] D79328: lld: Let find_package(LLD) work

[Shoaib Meenai via Phabricator via llvm-commits]

smeenai added reviewers: ruiu, grimar, rnk, mstorsjo, MaskRay, psmith.
smeenai added a comment.

In D79328#2035284 <https://reviews.llvm.org/D79328#2035284>, @arsenm wrote:

> In D79328#2035234 <https://reviews.llvm.org/D79328#2035234>, @smeenai wrote:
>
> > LGTM, given it's basically just matching what clang already does.
> >
> > > I'm slightly confused since it looks like the build is manually
> > >  generating a very similar *Targets.cmake to what gets auto-generated
> > >  by export(). After generating the build, I see:
> > > 
> > >   build/tools/lld/cmake/modules/CMakeFiles/Export/lib/cmake/lld/LLDTargets.cmake
> > >   build/lib/cmake/lld/LLDTargets.cmake
> > >   build/tools/clang/cmake/modules/CMakeFiles/Export/lib/cmake/clang/ClangTargets.cmake
> > >   build/lib/cmake/clang/ClangTargets.cmake
> > > 
> > > The cmake generated one "wins" and is what I see in the installed
> > >  tree. I'm guessing this is somehow for the benefit of old versions
> > >  of cmake?
> >
> > I believe both the CMakeFiles version and the lib version are generated by CMake. The first one should just be an internal CMake file.
>
>
> Any comment on "lld" vs "LLD"? Should the project() name be capitalized?


Not sure ... I think LLD is more common, but e.g. the directory is named lld. Adding a bunch of LLD COFF and ELF folks to see if they have any opinions there.

The only effect the `project()` name would have would be the various variables that CMake sets based on it (https://cmake.org/cmake/help/latest/command/project.html), but I don't think we're using any of those.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79328/new/

https://reviews.llvm.org/D79328