[PATCH] D79900: [BitcodeReader] datalayout must be specified before it is queried.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 13 14:10:03 PDT 2020


efriedma added a comment.

> If you remove the datalayout string from test/CodeGen/AMDGPU/vector-alloca-bitcast.ll for example, does it work with this patch?

This patch doesn't have any effect except to reject certain unusual bitcode files not generated by LLVM.

If you're asking about D78403 <https://reviews.llvm.org/D78403>, that doesn't affect the general rules for what tools overwrite the datalayout based on the TargetMachine.  Currently, llc always does this, and opt never does this.  So the error messages for that sort of thing should remain the same.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79900/new/

https://reviews.llvm.org/D79900





More information about the llvm-commits mailing list