[PATCH] D79162: [Analysis] TTI: Add CastContextHint for getCastInstrCost

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 13 13:03:55 PDT 2020


efriedma added a comment.

The general idea of passing down information about the instruction makes sense.

The one thing I would say here is that we probably shouldn't pass down the "Instruction" from the vectorizer at all: in general, the cost computation doesn't know what sort of transforms the vectorizer is going to do, so any information computed from its operands/uses will be misleading in general.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79162/new/

https://reviews.llvm.org/D79162





More information about the llvm-commits mailing list