[PATCH] D79775: [AsmPrinter] Handle foldable FP constant exprs in initializers.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 13 11:25:15 PDT 2020


efriedma added a comment.

> Hm, the version I am looking at seems to only return true for GlobalValues & block addresses in functions needing relocations. https://github.com/llvm/llvm-project/blob/master/llvm/lib/IR/Constants.cpp#L553

Oh, hmm, somehow I thought it was different.

We probably need some common helper that actually does what we want, somewhere, so we don't have duplicate code for figuring out whether it's legal to promote a constant to a global.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79775/new/

https://reviews.llvm.org/D79775





More information about the llvm-commits mailing list