[PATCH] D79779: [CodeGen] Make CreateStackTemporary work for scalable vectors

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 13 10:50:29 PDT 2020


efriedma added a comment.

I would split the patch into the following steps:

1. Introduce the new `CreateStackTemporary(TypeSize, Align)` API, and refactor the code.
2. Set the StackID in CreateStackTemporary
3. Fix the APIs that take a VT to choose more appropriate alignment.  This is the hard part; probably requires some work to make the interaction between the alignment assumed by the users, vs. the actual alignment, work correctly.  Probably makes sense to do this last; you might end up splitting this into multiple patches and/or change users of the API.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79779/new/

https://reviews.llvm.org/D79779





More information about the llvm-commits mailing list