[PATCH] D77232: [mlir][GPUToSPIRV] Make spv.interface_var_abi attribute on arguments either be unspecified on all arguments to use default ABI, or be present on all arguments.

[Lei Zhang via Phabricator via llvm-commits]

antiagainst accepted this revision.
antiagainst marked an inline comment as done.
antiagainst added a comment.
This revision is now accepted and ready to land.

It would be nice to have a shorter oneliner for the first paragraph of the commit message and put the details in the second paragraph.



================
Comment at: mlir/test/Conversion/GPUToSPIRV/simple.mlir:40
+    // CHECK-SAME: spv.entry_point_abi = {local_size = dense<[32, 4, 1]> : vector<3xi32>}
+    gpu.func @basic_module_structure_preset_ABI(
+      %arg0 : f32
----------------
mravishankar wrote:
> antiagainst wrote:
> > I think we can just test the gpu.func itself without the wrapping gpu.module and the corresponding launch op? This way it's clearer regarding the intended use case of attaching these attributes: it gives us a way to use and control the CodeGen side as a stand-alone component. :)
> Apparently the `gpu.module` is needed (`gpu.func` must have this as parent). Removed the funcOp that invokes the kernel though.
Oh right. A recent change made gpu.func must appear in gpu.module


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77232/new/

https://reviews.llvm.org/D77232