[PATCH] D79428: [WebAssembly] Added Debug Fixup pass

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added inline comments.


================
Comment at: llvm/test/CodeGen/WebAssembly/stackified-debug.ll:58
+  ret void, !dbg !22
+}
+
----------------
aheejin wrote:
> Nit: We may not need `bitcast`s and `tail call`s. How about making this simpler by something like
> ```                                                                           
> define void @foo() {                                                             
> entry:                                                                           
>   %call = call i32 @input()
>   call void @llvm.dbg.value(metadata i32 %call, metadata !16, metadata !DIExpression()), !dbg !19                                                  
>   %call1 = call i32 @input()
>   call void @llvm.dbg.value(metadata i32 %call1, metadata !17, metadata !DIExpression()), !dbg !19                                            
>   call void @output(i32 %call, i32 %call1)                                       
>   ret void                                                                       
> }                                                                                
>                                                                                  
> declare i32 @input()                                                             
> declare void @output(i32, i32)
> ```
> ? (This does not include `llvm.dbg.value`; they have to be added)
> Also it looks we don't need `attributes` and `local_unnamed_addr`s for this test.
> 
> Also it'd be better to add a test case when `llvm.dbg.value` is not right after its corresponding def instruction.
"(This does not include llvm.dbg.value; they have to be added)" was added by mistake, nvm


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79428/new/

https://reviews.llvm.org/D79428