[PATCH] D79829: [mlir][Affine][NFCI]: Introduce affine memory interfaces

[Uday Bondhugula via Phabricator via llvm-commits]

bondhugula added a comment.

This looks really great! Thanks. CMake dependences and linking can be tricky; please make sure to build/test without LLD as well in case you are using LLD since there are a bunch of dependences / CMakelists.txt that need an update.



================
Comment at: mlir/lib/Dialect/Affine/IR/AffineOps.cpp:2564-2581
+/// Get memref operand.
+Value AffineVectorLoadOp::getMemRef() {
+  return getOperand(getMemRefOperandIndex());
+}
+
+MemRefType AffineVectorLoadOp::getMemRefType() {
+  return getMemRef().getType().cast<MemRefType>();
----------------
I missed why we need to introduce these here? Shouldn't they be shared via the op interface method?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79829/new/

https://reviews.llvm.org/D79829