[PATCH] D79779: [CodeGen] Make CreateStackTemporary work for scalable vectors

Tue May 12 23:57:41 PDT 2020

david-arm marked an inline comment as done.
david-arm added inline comments.

================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp:2020
+  const Align Alignment =
+      std::max(std::min(PrefAlign, StackAlign), Align(minAlign));
+  return CreateStackTemporary(VT.getStoreSize(), Alignment);
----------------
sdesmalen wrote:
> Can you split this patch up into two patches:
> - one that prevents the stack temporary to exceed the stack alignment (which also needs tests for fixed-width vectors). Please also add @efriedma as reviewer to these patches, since he recently fixed a very similar problem in D79532.
> - another to make createStackTemporary support scalable types.
Sure. It will take me a long time to get a patch ready for the stack alignment fix anyway due to it breaking 64 tests!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79779/new/

https://reviews.llvm.org/D79779