[PATCH] D79797: [lld-macho] Ignore -platform_version and -syslibroot flags.

Tue May 12 17:48:24 PDT 2020

int3 marked an inline comment as done.
int3 added inline comments.

================
Comment at: lld/test/MachO/platform-version.test:11-12
+# RUN:     | FileCheck --check-prefix=GOOD %s
+# RUN: not lld -flavor darwinnew -platform_version macos 10.15 10.15.4 foobar 2>&1 \
+# RUN:     | FileCheck --check-prefix=FAIL_FILE %s
+
----------------
thakis wrote:
> int3 wrote:
> > not sure this test really fits into this file, but not a big deal I guess
> The idea is to test that the 4th parameter after `-platform_version` isn't ignored. Passing a non-existent input was the best thing I could think of. I guess I could try a `-l` flag instead and then pass an existing input that needs the -l to successfully link, but it's a bit more boilerplate. Let me know if you prefer that and I'll change it in a follow-up.
Ah got it. It's fine this way, thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79797/new/

https://reviews.llvm.org/D79797