[PATCH] D79820: [test] Improve FileCheck's numeric-expression.txt

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 12 16:09:52 PDT 2020


thopre created this revision.
thopre added reviewers: jhenderson, jdenny, probinson, grimar, arichardson, rnk.
thopre added a project: LLVM.
thopre added a parent revision: D77741: [FileCheck] Better diagnostic for format conflict.
thopre added a child revision: D60390: FileCheck [10/12]: Add support for signed numeric values.
thopre updated this revision to Diff 263553.
thopre added a comment.

Fix format of repositionned CHECK directive


Various improvement for FileCheck's numeric-expression.txt test:

- remove unused values in USE DEF FMT IMPL MATCH section
- replace 14 literal for 0xe and 0xE to have example of hex literals
- add comment next to values being matched to help readability
- add conversion tests
- adjust position of error message check to match the alignment of the error message wrt. the output matched by the previous check


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D79820

Files:
  llvm/test/FileCheck/numeric-expression.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D79820.263553.patch
Type: text/x-patch
Size: 3237 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200512/dbefb38b/attachment-0001.bin>


More information about the llvm-commits mailing list