[PATCH] D79794: Change the INLINEASM_BR MachineInstr to be a non-terminating instruction.

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 12 12:21:55 PDT 2020


craig.topper added a comment.

In D79794#2032052 <https://reviews.llvm.org/D79794#2032052>, @nickdesaulniers wrote:

> An interesting approach.  It certainly seems to simplify some of the special handling.  I'm happy that it seems to delete much of the existing code.  Thank you for taking the time to write up this patch.


This is funny. The original asm goto patches started off with just using INLINEASM and trying to follow exception handling. We switched to INLINEASM_BR as a terminator to "simplify" things.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79794/new/

https://reviews.llvm.org/D79794





More information about the llvm-commits mailing list