[PATCH] D79771: [examples] Skip building the Bye pass plugin on windows

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 12 10:11:59 PDT 2020


mstorsjo added a comment.

In D79771#2031812 <https://reviews.llvm.org/D79771#2031812>, @amccarth wrote:

> > Windows doesn't properly support pass plugins (as a shared library can't have undefined references, which pass plugins assume, being loaded into a host process that contains provides them)
>
> This sounds like a problem with the plugin design.  Is this patch intended as a temporary workaround until the inherent layering problem is resolved?


I'm not planning on addressing the general pass plugin design, I just want builds with `-DBUILD_SHARED_LIBS=TRUE`. The fact that pass plugin can't work on windows is known since https://reviews.llvm.org/D47082 at least, without any plans from others to do anything about it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79771/new/

https://reviews.llvm.org/D79771





More information about the llvm-commits mailing list