[PATCH] D79600: [TargetLoweringObjectFileImpl] Produce .text.hot. instead of .text.hot for -fno-unique-section-names

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

In D79600#2031300 <https://reviews.llvm.org/D79600#2031300>, @psmith wrote:

> I don't have a lot to add. I think this change will work with LLD and the GNU tools, no objections to this change. Having LLD not recognise the section names without a suffix may become a problem if GNU tools still output them. My guess is that LLD is still most used with clang at the moment, but this may change over time.


Yes, this will work with lld, GNU ld and gold. Your concern may be that GCC will still emit `.text.exit`? It emits `.text.exit.*` (function section manner). It does not support -fno-unique-section-names. Part of the reasons is that the related GNU as feature is a fairly new addition 2020-02 http://sourceware.org/PR25380 (I am going to raise a GCC feature request.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79600/new/

https://reviews.llvm.org/D79600