[PATCH] D79739: Adding Extra Runtime Functions to OMPKinds.def

Tue May 12 09:07:09 PDT 2020

jdoerfert added a subscriber: fghanim.
jdoerfert added a comment.

In D79739#2031394 <https://reviews.llvm.org/D79739#2031394>, @jhuber6 wrote:

> Should I start adding the target offload runtime functions?

You can, maybe open a second review based on this one.

================
Comment at: llvm/include/llvm/Frontend/OpenMP/OMPKinds.def:431
+__OMP_RTL(__kmpc_omp_task_alloc, false, Int8Ptr, IdentPtr, Int32, Int32, Int64,
+          Int64, TaskRoutineEntryPtr)
+__OMP_RTL(__kmpc_omp_task, false, Int32, IdentPtr, Int32, Int8Ptr)
----------------
jhuber6 wrote:
> Functions like this one use "size_t" which would be a 32 bit integer on a 32 bit system, but I've just set it to 64 bits for now. Should I add some macro's to set it to an Int32 or Int64 depending on the target? The tests target a 64 bit system and I can't see many people using OpenMP on a 32 bit computer so I wasn't sure if I should bother.
@fghanim has a solution for `int` and `size_t` in D79675. We can merge that part separately as I noted in that review. We should utilize those types in this patch right away.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79739/new/

https://reviews.llvm.org/D79739