[PATCH] D79165: [DebugInfo] - DWARFDebugFrame: do not call abort() on errors.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue May 12 08:01:49 PDT 2020
grimar added inline comments.
================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:816
isLittleEndian(), DObj->getAddressSize());
- DebugFrame.reset(new DWARFDebugFrame(getArch(), false /* IsEH */));
- DebugFrame->parse(debugFrameData);
+ std::unique_ptr<DWARFDebugFrame> debugFrame =
+ std::make_unique<DWARFDebugFrame>(getArch(), /*IsEH=*/false);
----------------
jhenderson wrote:
> What do you think about fixing the naming of this variable to use UpperCamelCase here? (I see there might be some concerns, hence the question).
Ok, since it was introduced by this patch.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79165/new/
https://reviews.llvm.org/D79165
More information about the llvm-commits
mailing list