[PATCH] D79578: [mlir] NFC: Rename LoopOps dialect to SCF (Structured Control Flow)

Tue May 12 04:47:53 PDT 2020

ftynse added a comment.

In D79578#2029832 <https://reviews.llvm.org/D79578#2029832>, @PeteSteinfeld wrote:

> > I don't think this is the request. The request is just "don't break the build". 
> >  The pre-merge testing will test flang as well, but you would have had to rebase the patch after you landed the dependent ones first so that the pre-merge testing could work (I think marking the dependencies in Phabricator would have worked also).
> > 
> > In general trying to get the pre-merge testing green before pushing changes is safer.
>
> Yes, the request is to not break the build.

This is standard policy. So is reverting the breaking changes. Sometimes we do break stuff and there are technical solutions to decrease the probability of this happening.

I am however opposed to having to contact someone other than people who would normally review the patch. If something is not covered by `check-flang` (which I forgot to run, I admit, that's why we need automation!) or any other simple command, I think it is unreasonable to block us from working and wait for somebody to think about how the changes might affect dependent projects.

> And in the case where the pre-merge testing is not working, I encourage you to contact @schweitz or @PeteSteinfeld or any other member of the flang team to verify that our builds succeed.

Thanks for offering help! Note that I still don't know who "any other member"s are, is there a list? a chat channel?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79578/new/

https://reviews.llvm.org/D79578