[PATCH] D79074: [PowerPC] Respect SDNodeFlags in lowering SELECT_CC
Qing Shan Zhang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon May 11 23:57:39 PDT 2020
steven.zhang accepted this revision.
steven.zhang added a comment.
LGTM now.
================
Comment at: llvm/test/CodeGen/PowerPC/scalar_cmp.ll:129
; NO-FAST-P9: # %bb.0: # %entry
-; NO-FAST-P9-NEXT: fcmpu cr0, f1, f2
-; NO-FAST-P9-NEXT: beq cr0, .LBB2_2
-; NO-FAST-P9-NEXT: # %bb.1: # %entry
-; NO-FAST-P9-NEXT: fmr f3, f4
-; NO-FAST-P9-NEXT: .LBB2_2: # %entry
-; NO-FAST-P9-NEXT: fmr f1, f3
+; NO-FAST-P9-NEXT: xssubsp f0, f2, f1
+; NO-FAST-P9-NEXT: xssubsp f1, f1, f2
----------------
These instructions sequence seem terrible to me, as we didn't have INF and NAN for this case. But it is not relative with your change, maybe, worth to take a look.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D79074/new/
https://reviews.llvm.org/D79074
More information about the llvm-commits
mailing list