[PATCH] D79759: [mlir] Add SubViewOp::getOrCreateRanges and fix folding pattern

[Mahesh Ravishankar via Phabricator via llvm-commits]

mravishankar resigned from this revision.
mravishankar added a comment.

Not familiar with the folding patterns for memref cast as much, but it seems fine to me. Please let someone with more knowledge of this to review it as well.



================
Comment at: mlir/lib/Dialect/StandardOps/IR/Ops.cpp:2574
 /// Pattern to rewrite a subview op with constant arguments.
-class SubViewOpFolder final : public OpRewritePattern<SubViewOp> {
+class SubViewOpConstantFolder final : public OpRewritePattern<SubViewOp> {
 public:
----------------
Nit: this name is misleading. How about SubViewOpConstantArgumentFolder ? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79759/new/

https://reviews.llvm.org/D79759