[llvm] 1f707cc - Partially revert "[CMake] Fix building with -DBUILD_SHARED_LIBS=ON on mingw"

Martin Storsjö via llvm-commits llvm-commits at lists.llvm.org
Mon May 11 22:21:53 PDT 2020


Author: Martin Storsjö
Date: 2020-05-12T08:20:44+03:00
New Revision: 1f707cc9908173951fe7ed0a2d8e90dc8923651d

URL: https://github.com/llvm/llvm-project/commit/1f707cc9908173951fe7ed0a2d8e90dc8923651d
DIFF: https://github.com/llvm/llvm-project/commit/1f707cc9908173951fe7ed0a2d8e90dc8923651d.diff

LOG: Partially revert "[CMake] Fix building with -DBUILD_SHARED_LIBS=ON on mingw"

This reverts parts of commit 609ef948387ba40e3693c2bd693d82ca34dcdc02,
as it caused build failures on windows if LLVM_BUILD_EXAMPLES was
enabled, due to Bye being added as a dependency of the lit tests.

Added: 
    

Modified: 
    llvm/examples/Bye/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/llvm/examples/Bye/CMakeLists.txt b/llvm/examples/Bye/CMakeLists.txt
index 362086eb1b32..3206f90d0916 100644
--- a/llvm/examples/Bye/CMakeLists.txt
+++ b/llvm/examples/Bye/CMakeLists.txt
@@ -2,18 +2,12 @@ if(LLVM_BYE_LINK_INTO_TOOLS)
   message(WARNING "Setting LLVM_BYE_LINK_INTO_TOOLS=ON only makes sense for testing purpose")
 endif()
 
-# The plugin expects to not link against the Support and Core libraries,
-# but expects them to exist in the process loading the plugin. This doesn't
-# work with DLLs on Windows (where a shared library can't have undefined
-# references), so just skip this testcase on Windows.
-if (NOT WIN32)
-  add_llvm_pass_plugin(Bye
-    Bye.cpp
-    DEPENDS
-    intrinsics_gen
-    BUILDTREE_ONLY
-   )
+add_llvm_pass_plugin(Bye
+  Bye.cpp
+  DEPENDS
+  intrinsics_gen
+  BUILDTREE_ONLY
+ )
 
-  install(TARGETS ${name} RUNTIME DESTINATION examples)
-  set_target_properties(${name} PROPERTIES FOLDER "Examples")
-endif()
+install(TARGETS ${name} RUNTIME DESTINATION examples)
+set_target_properties(${name} PROPERTIES FOLDER "Examples")


        


More information about the llvm-commits mailing list