[PATCH] D79468: [mlir][Linalg] Start a LinalgToStandard pass and move conversion to library calls.

Nicolas Vasilache via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 11 21:03:46 PDT 2020


nicolasvasilache marked 2 inline comments as done.
nicolasvasilache added a comment.

> so the new uses introduced here and the their lowering directly contradict what is stated in the doc.

Here, I fixed it :)

  The `memref_cast` operation converts a memref from one type to an equivalent
  type with a compatible shape. The source and destination types are
  compatible if both are ranked memref types with the same element type,
  address space, and rank but where the individual dimensions may add or
  remove constant dimensions from the memref type.

More seriously, I think this is an oversight since the doc examples and the impl contradict the "same layout" part.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79468/new/

https://reviews.llvm.org/D79468





More information about the llvm-commits mailing list