[PATCH] D79662: [mlir] Revisit std.subview handling of static information.

[Lei Zhang via Phabricator via llvm-commits]

antiagainst added a comment.

Awesome! This is a nice clean up, thanks Nicolas!



================
Comment at: mlir/include/mlir/Dialect/StandardOps/IR/Ops.td:2692
+    static ArrayRef<StringRef> getSpecialAttrNames() {
+      static SmallVector<StringRef, 4> names{
+        getStaticOffsetsAttrName(),
----------------
Won't a plain `StringRef[4]` work here? That will help with initialization and lifetime?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79662/new/

https://reviews.llvm.org/D79662