[PATCH] D77560: [SCEV] CreateNodeForPhi should return SCEVUnknown for incomplete PHIs

wael yehia via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 11 10:11:58 PDT 2020


w2yehia added a comment.

gentle ping. 
Just to summarize. The testcase demonstrating the issue is added to `llvm/unittests/Analysis/ScalarEvolutionTest.cpp`. 
The description of what the issue is, is in the "The problem" section in the description of this review. 
The solution implemented in this review is to detect when an "incomplete" PHI is being `createSCEV`'ed  and return a SCEVUnknown.
Feedback is greatly appreciated.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77560/new/

https://reviews.llvm.org/D77560





More information about the llvm-commits mailing list