[PATCH] D74794: [X86][ISelLowering] refactor Varargs handling in X86ISelLowering.cpp

Arthur Eubanks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 11 07:29:25 PDT 2020


aeubanks added a comment.

Looks much better, just one small question.



================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:3523-3524
+                                                   unsigned StackSize) {
+  FuncInfo->setVarArgsFrameIndex(0xAAAAAAA);
+  FuncInfo->setRegSaveFrameIndex(0xAAAAAAA);
+
----------------
This isn't the exact same logic as before, is that intended?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74794/new/

https://reviews.llvm.org/D74794





More information about the llvm-commits mailing list