[PATCH] D79664: [ELF] Support --pack-dyn-relocs=rel+relr

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 9 11:09:07 PDT 2020


MaskRay added a comment.

I haven't thought much on this yet. First impression: why isn't the RELA->REL toggle a new option? It does not seem to fit with the rest of --pack-dyn-relocs which selects Android packed dynamic relocations or RELR or both.

Regarding tests, you can add `llvm-readelf -S` RUN lines to check `.rel.dyn` or `.rela.dyn`. See some newly touched test files.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79664/new/

https://reviews.llvm.org/D79664





More information about the llvm-commits mailing list