[PATCH] D79549: [LoopReroll] Fix rerolling loop with use outside the loop

KAWASHIMA Takahiro via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 8 23:04:10 PDT 2020


kawashima-fj marked an inline comment as done.
kawashima-fj added a comment.

In D79549#2027214 <https://reviews.llvm.org/D79549#2027214>, @efriedma wrote:

> Could you take another look at the testcase for 34760 in particular?  That seems similar enough that it should get fixed at the same time.


My change does not fix PR34760.
I tried the original reporter's precedure. LLVM bofore this change and after this change both give the same incorrect value (8).
I also tried `opt -S -loop-reroll` for the bitcode attached in the Comment 2. LLVM bofore this change and after this change both give same IR.
I read the bitcode attached in the Comment 2. It is not the pattern which I fixed.

In a quick glance, the problem of PR34760 is in the IR rewriting phase, not in the analysing/validating phase. I'll put a comment to PR34760 later.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79549/new/

https://reviews.llvm.org/D79549





More information about the llvm-commits mailing list