[PATCH] D79640: Add Operation::moveAfter

Uday Bondhugula via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 8 18:49:18 PDT 2020


bondhugula added a comment.

In D79640#2027782 <https://reviews.llvm.org/D79640#2027782>, @GMNGeoffrey wrote:

> Pardon my phabricator ignorance, but why is the comment here "This revision was not accepted when it landed; it landed in state Needs Review" immediately below "mehdi_amini accepted this revision"? Is that because River is marked as a blocking reviewer? Seems like a fragile system to have one person be the only one who can approve some set of code. What if they go on vacation?


This is a good point. Would someone have access / permissions to substitute a blocking reviewer in such cases when the blocking reviewer may not be available?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79640/new/

https://reviews.llvm.org/D79640





More information about the llvm-commits mailing list