[PATCH] D76877: Implement DW_CFA_LLVM_* for Heterogeneous Debugging

[Scott Linder via Phabricator via llvm-commits]

scott.linder marked 2 inline comments as done.
scott.linder added inline comments.


================
Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFDebugFrame.h:36
 public:
   typedef SmallVector<uint64_t, 2> Operands;
 
----------------
RamNalamothu wrote:
> Now, maximum number of operands is 3
Thank you, I'll update the patch.


================
Comment at: llvm/lib/MC/MCDwarf.cpp:1430
+    unsigned AddressSpace = Instr.getAddressSpace();
+    Streamer.emitIntValue(dwarf::DW_CFA_LLVM_def_aspace_cfa, 1);
+    Streamer.emitULEB128IntValue(Reg);
----------------
RamNalamothu wrote:
> Emitting //DW_CFA_def_aspace_cfa_sf// is yet to be handled?
> 
> I see that even the emission of DWARF 5 supported //DW_CFA_def_cfa_sf// and //DW_CFA_def_cfa_offset_sf// are also yet to be handled.
Right, this should probably be a TODO in the code. As the existing `_sf` variants are not implemented yet either and AMDGPU does not currently require any of them (we always retain a copy of the stack pointer on entry in some form) I didn't implement it here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D76877/new/

https://reviews.llvm.org/D76877