[PATCH] D79373: [mlir] Add FPToSIOp to Standard dialect.

Han-Chung Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 8 13:26:05 PDT 2020


hanchung added a comment.

In D79373#2026852 <https://reviews.llvm.org/D79373#2026852>, @antiagainst wrote:

> In D79373#2023053 <https://reviews.llvm.org/D79373#2023053>, @mravishankar wrote:
>
> > Looks good to me. Please wait for River to accept.
>
>
> I think River's concerns were addressed. He is OOO for the next week; let's land this and we can always fix afterwards if he has more concerns.


Sounds good to me. @rriddle Feel free to ping me or leave comments here if there are other concerns. I'm happy to address them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79373/new/

https://reviews.llvm.org/D79373





More information about the llvm-commits mailing list