[PATCH] D79489: [mlir][Linalg] NFC - Refactor and simplify Promotion

[Mahesh Ravishankar via Phabricator via llvm-commits]

mravishankar accepted this revision.
mravishankar added a comment.
This revision is now accepted and ready to land.

Could you let me know when you are done with most refactoring so that I can pick up some other things that intersected with this refactoring work. I dont want to be touching the same code will its being modified.



================
Comment at: mlir/lib/Dialect/Linalg/Transforms/Promotion.cpp:208
     // boundary.
     linalg_fill(info->second.fullLocalView, fillVal);
   }
----------------
nicolasvasilache wrote:
> mravishankar wrote:
> > I think these fill needs to have the marker added to it too. If not they can be intercepted by the pattern rewriter which would try to apply transformations on them (AFAIK the marker is supposed to prevent that).
> > Same is true for the linalg_copy below.
> I am envisioning is an analysis would place markers that will trigger patterns.
> Anything unmarked would not be rewritten in the first place.
> 
> I think we can experiment with different scenarios in the future.
> In any case, changing this now would make the revision non-NFC.
Ok, lets sync about this offline. Maybe the way I was thinking about this is reverse from what you mentioned. By reading the code, I was thinking that you do a transformation and set a marker, preventing it from being transformed again. But what is being done is that it is setting the maker for the next stage of transformation to kick in. I need to account for this in IREE codegen. Will take a look after all the refactoring is done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79489/new/

https://reviews.llvm.org/D79489