[PATCH] D79371: [ELF] Add convenience TableGen classes to enforce two dashes for options not supported by GNU ld

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

In D79371#2026540 <https://reviews.llvm.org/D79371#2026540>, @MaskRay wrote:

> In D79371#2026499 <https://reviews.llvm.org/D79371#2026499>, @tejohnson wrote:
>
> > LGTM. But you should add -omagic in the summary and release notes.
>
>
> --omagic is already correct.
>
>   def omagic: Flag<["--"], "omagic">, MetaVarName<"<magic>">,
>     HelpText<"Set the text and data sections to be readable and writable, do not page align sections, link against static libraries">;
>
>
> It was 2000's GNU ld which changed the behavior.


Got it, missed the fact that this was a noop change to use the new convenience class.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79371/new/

https://reviews.llvm.org/D79371