[PATCH] D78804: [LICM] Precompute memory writers for AST aliasing analysis

[Max Kazantsev via Phabricator via llvm-commits]

mkazantsev marked an inline comment as done.
mkazantsev added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/LICM.cpp:143
                   BasicBlock *Dest, ICFLoopSafetyInfo *SafetyInfo,
+                  Optional<DenseSet<Instruction *> > LoopMemWrites,
                   MemorySSAUpdater *MSSAU, ScalarEvolution *SE,
----------------
mkazantsev wrote:
> asbirlea wrote:
> > ` Optional<DenseSet<Instruction *> > ` clang-format adds that space between `> >`?
> > It's consistent throughout, so I guess so...it just looks odd to me :-).
> Will double-check, but I guess it was clang-format. 
Yes, it must be legacy since times where C++ parser was confusing `<X <Y>>` with shift. :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78804/new/

https://reviews.llvm.org/D78804