[PATCH] D79602: [SimplifyCFG] Remap rewritten debug intrinsic operands.

[Ricky Zhou via Phabricator via llvm-commits]

rickyz marked an inline comment as done.
rickyz added inline comments.


================
Comment at: llvm/test/DebugInfo/simplify-cfg-preserve-dbg-values.ll:116
+!0 = distinct !DICompileUnit(language: DW_LANG_C_plus_plus, file: !1, producer: "clang version 8.0.1-4 (tags/RELEASE_801/final)", isOptimized: true, runtimeVersion: 0, emissionKind: FullDebug, enums: !2, nameTableKind: None)
+!1 = !DIFile(filename: "/usr/local/google/home/rickyz/test.cc", directory: "/usr/local/google/home/rickyz")
+!2 = !{}
----------------
djtodoro wrote:
> `filename: "test.cc", directory: "/dir"`
I completely missed that these snuck in - thanks for catching!


================
Comment at: llvm/test/DebugInfo/simplify-cfg-preserve-dbg-values.ll:137
+!21 = !{!"Simple C++ TBAA"}
+!22 = !DILocation(line: 3, column: 3, scope: !7)
+!23 = !DILocation(line: 3, column: 8, scope: !7)
----------------
djtodoro wrote:
> Little trick to trim the test: you can use only one location for all other locations with the same scope, e.g.:
> 
> all !`dbg !23, !dbg !24, !dbg !25, !dbg !26` replace with `!dbg !22`, and then delete these unused`DILocations`
Done - also removed the !range metadata, which didn't seem to be needed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79602/new/

https://reviews.llvm.org/D79602