[PATCH] D78736: [DWARF5]: Added support for dumping strx forms in llvm-dwarfdump

Igor Kudrin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 8 01:34:30 PDT 2020


ikudrin added a comment.

LGTM with a nit. Please wait a couple of days in case other reviewers have anything to say,



================
Comment at: llvm/test/DebugInfo/X86/debug-macro-empty-str-offset.s:2
+## This test checks that llvm-dwarfdump produces error message
+## while parsing an *_strx form, if units contribution to 
+## debug_str_offsets[.dwo] section is missing.
----------------
Remove trailing whitespace in this line.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78736/new/

https://reviews.llvm.org/D78736





More information about the llvm-commits mailing list