[PATCH] D79600: [TargetLoweringObjectFileImpl] Produce .text.hot. instead of .text.hot for -fno-unique-section-names

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 7 16:51:51 PDT 2020


MaskRay added a comment.

In D79600#2026282 <https://reviews.llvm.org/D79600#2026282>, @wmi wrote:

> Although less likely, is there possiblity that someone has already been using __attribute__((section(".text.hot."))? Adding another trailing period will break the existing usage. We may either tolerate that case, or trigger an assertion.


`__attribute__((section(".text.hot."))` overrides the default section name `.text.$function` or `.text.$prefix.$function`

`__attribute__((section(".text.hot."))) int foo() { return 42; }` produces `.text.hot.` with or without -ffunction-sections


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79600/new/

https://reviews.llvm.org/D79600





More information about the llvm-commits mailing list