[PATCH] D77523: Add CanonicalizeFreezeInLoops pass

[Juneyoung Lee via Phabricator via llvm-commits]

aqjune marked an inline comment as not done.
aqjune added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/CanonicalizeFreezeInLoops.cpp:229
+  AU.addRequired<DominatorTreeWrapperPass>();
+  AU.addPreserved<DominatorTreeWrapperPass>();
+}
----------------
efriedma wrote:
> aqjune wrote:
> > efriedma wrote:
> > > getLoopAnalysisUsage?
> > Seems like using getLoopAnalysisUsage affects the code generation of LSR even if the pass is doing nothing, causing tests such as CodeGen/X86/lsr-loop-exit-cond.ll fail.
> What, specifically, in getLoopAnalysisUsage is causing that?
> 
> If you're intentionally not using getLoopAnalysisUsage, please carefully document what you're doing here and in LSR.
It is because it calls AU.addRequiredID(LCSSAID) , and LSR does not require LCSSA.
I left a comment about this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77523/new/

https://reviews.llvm.org/D77523