[PATCH] D79549: [LoopReroll] Fix rerolling loop with use outside the loop

[Eli Friedman via Phabricator via llvm-commits]

efriedma added a comment.

I think there are four loop-reroll issues currently open in Bugzilla:

https://bugs.llvm.org/show_bug.cgi?id=34029
https://bugs.llvm.org/show_bug.cgi?id=42267
https://bugs.llvm.org/show_bug.cgi?id=34760
https://bugs.llvm.org/show_bug.cgi?id=41696

Could you check which ones this patch fixes?



================
Comment at: llvm/lib/Transforms/Scalar/LoopRerollPass.cpp:882
     return false;
+  if (hasUsesOutsideLoop(DRS.BaseInst, L))
+    return false;
----------------
Probably worth putting the "Check for other root instructions is unnecessary because they don't match any base instructions if they have uses outside the loop." explanation into a comment here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79549/new/

https://reviews.llvm.org/D79549