[PATCH] D79580: AMDGPU: Don't assert on unknown address spaces

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 7 11:57:07 PDT 2020


arsenm added a comment.

In D79580#2025685 <https://reviews.llvm.org/D79580#2025685>, @rampitec wrote:

> How do we get these address spaces? I'd rather error out.


You can use __attribute__((address_space)) or hand write IR. We should not error on valid IR. Someday a frontend may wish to track special information with a custom address space number, which we can handle as a global alias similar to how x86 accepts any arbitrary address space


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D79580/new/

https://reviews.llvm.org/D79580





More information about the llvm-commits mailing list