[PATCH] D77523: Add CanonicalizeFreezeInLoops pass

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 7 11:20:42 PDT 2020


efriedma added a comment.

I don't have any concerns about the general approach.  A couple drive-by comments.



================
Comment at: llvm/lib/Transforms/Utils/CanonicalizeFreezeInLoops.cpp:229
+  AU.addRequired<DominatorTreeWrapperPass>();
+  AU.addPreserved<DominatorTreeWrapperPass>();
+}
----------------
getLoopAnalysisUsage?


================
Comment at: llvm/lib/Transforms/Utils/CanonicalizeFreezeInLoops.cpp:264
+char CanonicalizeFreezeInLoops::ID = 0;
\ No newline at end of file

----------------
Newline


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D77523/new/

https://reviews.llvm.org/D77523





More information about the llvm-commits mailing list